simbadzina commented on PR #4584: URL: https://github.com/apache/hadoop/pull/4584#issuecomment-1194894453
Yes, it should be optional. Thanks for spotting the error. I'll fix that. I'm considering making the field a byte array in the client protocol. Only routers need to parse it. On Mon, Jul 25, 2022, 16:51 Erik Krogen ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto > <https://github.com/apache/hadoop/pull/4584#discussion_r929398786>: > > > @@ -157,6 +158,7 @@ message RpcResponseHeaderProto { > optional bytes clientId = 7; // Globally unique client ID > optional sint32 retryCount = 8 [default = -1]; > optional int64 stateId = 9; // The last written Global State ID > + map<string, int64> nameserviceStateIds = 10; // Last seen state IDs for multiple nameservices. > > Doesn't this field need to be optional for backwards compatibility? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/hadoop/pull/4584#discussion_r929398786>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AC6NI6DC23A4WNI4AARIIW3VV4SBNANCNFSM53457PHA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
