xkrogen commented on code in PR #4584:
URL: https://github.com/apache/hadoop/pull/4584#discussion_r929398786


##########
hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto:
##########
@@ -157,6 +158,7 @@ message RpcResponseHeaderProto {
   optional bytes clientId = 7; // Globally unique client ID
   optional sint32 retryCount = 8 [default = -1];
   optional int64 stateId = 9; // The last written Global State ID
+  map<string, int64> nameserviceStateIds = 10; // Last seen state IDs for 
multiple nameservices.

Review Comment:
   Doesn't this field need to be `optional` for backwards compatibility?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to