bziobrowski commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1935359600
########## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ########## @@ -140,7 +140,9 @@ public abstract class BaseSingleStageBrokerRequestHandler extends BaseBrokerRequ protected final int _defaultHllLog2m; protected final boolean _enableQueryLimitOverride; protected final boolean _enableDistinctCountBitmapOverride; - protected final int _queryResponseLimit; + protected final int _queryResponseLimitOverride; Review Comment: Done but I think current name isn't the best and ignores how the associated boolean flag is named - `_enableQueryLimitOverride`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
