gortiz commented on code in PR #14507:
URL: https://github.com/apache/pinot/pull/14507#discussion_r1895380119
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -484,6 +484,18 @@ default boolean defaultInferPartitionHint() {
return CommonConstants.Broker.DEFAULT_INFER_PARTITION_HINT;
}
+ /**
+ * Whether to use spools or not.
+ *
+ * This is treated as the default value for the broker and it is expected
to be obtained from a Pinot configuration.
+ * This default value can be always overridden at query level by the query
option
+ * {@link CommonConstants.Broker.Request.QueryOptionKey#USE_SPOOLS}.
+ */
+ @Value.Default
+ default boolean defaultUseSpools() {
+ return CommonConstants.Broker.DEFAULT_OF_SPOOLS;
+ }
Review Comment:
It is configurable. This is just the default value in case
`defaultUseSpools(boolean)` is not called (which is called in
`MultiStageBrokerRequestHandler`). It is following the same design principles
as `defaultInferPartitionHint` above. See
https://immutables.github.io/immutable.html#default-attributes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
