gortiz commented on code in PR #14507:
URL: https://github.com/apache/pinot/pull/14507#discussion_r1900913166
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/colocated/GreedyShuffleRewriteVisitor.java:
##########
@@ -209,22 +209,33 @@ public Set<ColocationKey>
visitMailboxSend(MailboxSendNode node, GreedyShuffleRe
boolean canSkipShuffleBasic = colocationKeyCondition(oldColocationKeys,
distributionKeys);
// If receiver is not a join-stage, then we can determine distribution
type now.
- if (!context.isJoinStage(node.getReceiverStageId())) {
- Set<ColocationKey> colocationKeys;
- if (canSkipShuffleBasic && areServersSuperset(node.getReceiverStageId(),
node.getStageId())) {
- // Servers are not re-assigned on sender-side. If needed, they are
re-assigned on the receiver side.
+ boolean sendsToJoin = false;
+ boolean allAreSuperSet = true;
+ for (Integer receiverStageId : node.getReceiverStageIds()) {
+ if (context.isJoinStage(receiverStageId)) {
+ sendsToJoin = true;
+ break;
+ }
Review Comment:
I've just changed this code to make it closer to the original code. I think
it will be easier to read this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
