gortiz commented on code in PR #14507:
URL: https://github.com/apache/pinot/pull/14507#discussion_r1888394357
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/BlockExchange.java:
##########
@@ -69,10 +76,11 @@ protected BlockExchange(List<SendingMailbox>
sendingMailboxes, BlockSplitter spl
* API to send a block to the destination mailboxes.
* @param block the block to be transferred
* @return true if all the mailboxes has been early terminated.
- * @throws Exception when sending stream unexpectedly closed.
+ * @throws IOException when sending stream unexpectedly closed.
+ * @throws TimeoutException when sending stream timeout.
*/
public boolean send(TransferableBlock block)
- throws Exception {
+ throws IOException, TimeoutException {
Review Comment:
this is more precise and IIRC we need to limit the scope of the exception in
order to create the BlockExchangeSendingMailbox
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
