gortiz commented on code in PR #14507:
URL: https://github.com/apache/pinot/pull/14507#discussion_r1895387864
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/InMemorySendingMailbox.java:
##########
@@ -106,4 +106,9 @@ public boolean isEarlyTerminated() {
public boolean isTerminated() {
return _isTerminated;
}
+
+ @Override
+ public String toString() {
+ return "m" + _id;
Review Comment:
I had to balance between long and easier to understand ids and short ones. I
would usually prefer the longer, but the logs that use these ids are already
very long, so I think having longer ids makes them even more difficult to read.
Also, given there are only 3 types of mailboxes and each one is named in a way
that the first character is unique, I think it is not very difficult to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
