vrajat commented on code in PR #14445:
URL: https://github.com/apache/pinot/pull/14445#discussion_r1841547166
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -707,6 +710,13 @@ public void start()
_serverQueriesDisabledTracker =
new ServerQueriesDisabledTracker(_helixClusterName, _instanceId,
_helixManager, serverMetrics);
_serverQueriesDisabledTracker.start();
+
+ long startupDurationMs = System.currentTimeMillis() - startTimeMs;
Review Comment:
I didnt think about the race condition and I agree that it doesnt matter.
The diff will be much simpler - only the timers and if-else condition is
required.
Also you will have to increment the failure metric in the catch block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
