jadami10 commented on code in PR #14445:
URL: https://github.com/apache/pinot/pull/14445#discussion_r1841541265
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -707,6 +710,13 @@ public void start()
_serverQueriesDisabledTracker =
new ServerQueriesDisabledTracker(_helixClusterName, _instanceId,
_helixManager, serverMetrics);
_serverQueriesDisabledTracker.start();
+
+ long startupDurationMs = System.currentTimeMillis() - startTimeMs;
Review Comment:
it can, but it's a small race condition. The server may have chosen to start
without startup status being `GOOD`, but it might be `GOOD` by the time we get
here. In practice, it probably doesn't matter. I don't have a strong opinion,
do you prefer I keep the code simpler with your approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
