vrajat commented on code in PR #14445:
URL: https://github.com/apache/pinot/pull/14445#discussion_r1841531696
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -520,7 +520,7 @@ private void setupHelixSystemProperties() {
*
* @param endTimeMs Timeout for the check
*/
- private void startupServiceStatusCheck(long endTimeMs) {
+ private boolean startupServiceStatusCheck(long endTimeMs, ServerMetrics
serverMetrics) {
Review Comment:
Is `serverMetrics` required here ? I dont see it being used.
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -707,6 +710,13 @@ public void start()
_serverQueriesDisabledTracker =
new ServerQueriesDisabledTracker(_helixClusterName, _instanceId,
_helixManager, serverMetrics);
_serverQueriesDisabledTracker.start();
+
+ long startupDurationMs = System.currentTimeMillis() - startTimeMs;
Review Comment:
The code can be simplified. `isStartupStatusCheckGood` is not required. It
should be sufficient to check `ServiceStatus.getServiceStatus(_instanceId)` and
then set the right service metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
