gortiz commented on code in PR #13733:
URL: https://github.com/apache/pinot/pull/13733#discussion_r1750217340
##########
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java:
##########
@@ -85,7 +85,7 @@ public class QueryContext {
private final int _offset;
private final Map<String, String> _queryOptions;
private final Map<ExpressionContext, ExpressionContext>
_expressionOverrideHints;
- private final boolean _explain;
+ private final ExplainMode _explain;
Review Comment:
I guess the naming is not the best. I found difficult to find a better name.
QueryMode is too generic and ends up meaning nothing.
Anyway, I don't think this should be nullable. First, because it is error
prone (as long as we don't use something like https://github.com/uber/NullAway
we are not going to be able to enforce nullability). Second, because if we used
`null` as _I don't want to explain_ it would be impossible to detect this case
vs _the request is not specified_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
