rohityadav1993 commented on code in PR #13837: URL: https://github.com/apache/pinot/pull/13837#discussion_r1740103413
########## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ########## @@ -78,11 +84,20 @@ public PinotSinkFunction(PinotGenericRowConverter<T> recordConverter, TableConfi _executorPoolSize = executorPoolSize; } + public PinotSinkFunction(PinotGenericRowConverter<T> recordConverter, TableConfig tableConfig, Schema schema, + long segmentFlushMaxNumRecords, int executorPoolSize, String segmentNamePrefix, Review Comment: Nullable, thanks for the suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org