rohityadav1993 commented on code in PR #13837: URL: https://github.com/apache/pinot/pull/13837#discussion_r1740102924
########## pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/BatchConfig.java: ########## @@ -52,7 +52,9 @@ public class BatchConfig { private final boolean _excludeSequenceId; private final boolean _appendUUIDToSegmentName; private final boolean _excludeTimeInSegmentName; + private final String _uploadedRealtimePartitionId; Review Comment: Would want to handle cases where _uploadedRealtimePartitionId is not set but needed. Can use Integer for clarity of type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org