tibrewalpratik17 commented on code in PR #13837:
URL: https://github.com/apache/pinot/pull/13837#discussion_r1726595303
##########
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/BatchConfigProperties.java:
##########
@@ -43,7 +43,9 @@ private BatchConfigProperties() {
public static final String TABLE_CONFIGS_URI = "tableConfigsURI";
public static final String SCHEMA = "schema";
public static final String SCHEMA_URI = "schemaURI";
+ public static final String PARTITION_ID = "partitionId";
public static final String SEQUENCE_ID = "sequenceId";
+ public static final String SEGMENT_CREATION_TIME_MS =
"segmentCreationTimeMs";
Review Comment:
nit: we should name this as `segmentUploadTimeMs` too for consistency across
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
