wirybeaver commented on code in PR #12532: URL: https://github.com/apache/pinot/pull/12532#discussion_r1533309390
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ########## @@ -350,58 +354,48 @@ private RoaringBitmap getMatchingFlattenedDocIds(Predicate predicate) { } } - @Override - public Map<String, RoaringBitmap> getMatchingDocsMap(String key) { - Map<String, RoaringBitmap> matchingDocsMap = new HashMap<>(); + @VisibleForTesting + public Map<String, RoaringBitmap> convertFlattenedDocIdsToDocIds(Map<String, RoaringBitmap> valueToFlattenedDocIds) { Review Comment: remove public? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org