wirybeaver commented on code in PR #12532:
URL: https://github.com/apache/pinot/pull/12532#discussion_r1533344161
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/json/ImmutableJsonIndexReader.java:
##########
@@ -317,51 +323,101 @@ private int getDocId(int flattenedDocId) {
return _docIdMapping.getInt((long) flattenedDocId << 2);
}
+ @VisibleForTesting
+ public Map<String, RoaringBitmap> convertFlattenedDocIdsToDocIds(Map<String,
RoaringBitmap> valueToFlattenedDocIds) {
Review Comment:
Make sense since the Transform function might be invoked multiple times.
Then we should remove VisibleForTesting? I just noticed that I incidentally
remove an optimization comment:
> I just realized that we should keep both valueToDocId and
valueToFlattenDocId. Using valueToFlattenDocIds would increase the read latency
since it need to iterate the flattenDocId bitmap and create the docId bitmap.
If the return type isSingleValue, init valueToDocId; otherwise, init
valueToFlattenDocIds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
