saurabhd336 commented on code in PR #12532:
URL: https://github.com/apache/pinot/pull/12532#discussion_r1533332454


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java:
##########
@@ -350,58 +354,48 @@ private RoaringBitmap 
getMatchingFlattenedDocIds(Predicate predicate) {
     }
   }
 
-  @Override
-  public Map<String, RoaringBitmap> getMatchingDocsMap(String key) {
-    Map<String, RoaringBitmap> matchingDocsMap = new HashMap<>();
+  @VisibleForTesting
+  public Map<String, RoaringBitmap> convertFlattenedDocIdsToDocIds(Map<String, 
RoaringBitmap> valueToFlattenedDocIds) {

Review Comment:
   This is now used to optimize SV extraction path by converting flattened doc 
IDs map to unflattened.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to