wirybeaver commented on code in PR #12532:
URL: https://github.com/apache/pinot/pull/12532#discussion_r1533195178
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/json/ImmutableJsonIndexReader.java:
##########
@@ -345,6 +370,103 @@ public Map<String, RoaringBitmap>
getMatchingDocsMap(String key) {
return matchingDocsMap;
}
+ @Override
+ public Map<String, RoaringBitmap> getValueToFlattenedDocIdsMap(String
jsonPathKey,
Review Comment:
Directly modify the getMatchingDocsMap which should have return
FlattenDocIds and move the converting of flattenDocIds to DocIds into the up
layer, i.e. transform function. I understand fixing the unit test JsonIndexTest
might take more time but it's worth to do that since more test cases can be
reused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
