deemoliu commented on PR #10915: URL: https://github.com/apache/pinot/pull/10915#issuecomment-1615301143
Addressed @Jackie-Jiang 's comment 1. used a double comparison column value in upsertConfig to replace upsertTTLConfig so it doesn't need to be timeInMills. 2. Persist largest seen timestamp which comes from addRecord as watermark per partition. it should be volatile. 3. Add delete watermark when the upsertConfig updated from ttl enabled to ttl-disabled. 4. move watermark related logics from BaseTableUpsertMetadataManager to BaseTableUpsertMetadataManager -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
