deemoliu commented on code in PR #10915: URL: https://github.com/apache/pinot/pull/10915#discussion_r1239008786
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java: ########## @@ -55,12 +64,17 @@ public class ConcurrentMapPartitionUpsertMetadataManager extends BasePartitionUp // Reused for reading previous record during partial upsert private final GenericRow _reuse = new GenericRow(); + private long _lastExpiredTimeMS; Review Comment: updated this value to _largestSeenComparisonValueMs and added more clear definition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
