vvivekiyer commented on code in PR #10845:
URL: https://github.com/apache/pinot/pull/10845#discussion_r1242534682
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java:
##########
@@ -309,8 +313,8 @@ public static AggregationFunction
getAggregationFunction(FunctionContext functio
case DISTINCTAVGMV:
return new DistinctAvgMVAggregationFunction(firstArgument);
case DISTINCT:
- return new DistinctAggregationFunction(arguments,
queryContext.getOrderByExpressions(),
Review Comment:
@Jackie-Jiang can we clean this up so that Distinct is not modeled as an
aggregation function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
