vvivekiyer commented on code in PR #10845:
URL: https://github.com/apache/pinot/pull/10845#discussion_r1242529302
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/ExpressionContext.java:
##########
@@ -74,8 +83,27 @@ public LiteralContext getLiteral(){
return _literal;
}
- public String getIdentifier() {
- return _identifier;
+ // Please check that the _type is Identifier before calling these functions.
+ public String getIdentifierName() {
+ if (_identifier == null) {
+ return null;
+ }
+
+ return _identifier.getName();
+ }
+
+ public int getIdentifierIndex() {
Review Comment:
Can we make this change contained in v2 (in NewAggregateOperator) so that we
don't need this interface change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
