vvivekiyer commented on code in PR #10845:
URL: https://github.com/apache/pinot/pull/10845#discussion_r1242513304
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/PhysicalPlanVisitor.java:
##########
@@ -96,10 +102,85 @@ public MultiStageOperator visitMailboxSend(MailboxSendNode
node, PhysicalPlanCon
@Override
public MultiStageOperator visitAggregate(AggregateNode node,
PhysicalPlanContext context) {
MultiStageOperator nextOperator = node.getInputs().get(0).visit(this,
context);
+ DataSchema inputSchema = node.getInputs().get(0).getDataSchema();
+ DataSchema resultSchema = node.getDataSchema();
+
+ // Convert aggCalls to FunctionContext and ExpressionContext that our
aggregation functions understand.
Review Comment:
Move this logic to convert RexExpression to
FunctionContext/ExpressionContext -> NewAggregateOperator.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
