gortiz commented on code in PR #10528:
URL: https://github.com/apache/pinot/pull/10528#discussion_r1209097820
##########
.github/workflows/pinot_tests.yml:
##########
@@ -72,16 +72,20 @@ jobs:
if: github.repository == 'apache/pinot'
runs-on: ubuntu-latest
strategy:
+ # Changed to false in order to improve coverage using unsafe buffers
+ fail-fast: false
matrix:
testset: [ 1, 2 ]
- name: Pinot Unit Test Set ${{ matrix.testset }}
+ java: [ 11, 17 ]
Review Comment:
I've just tried `mvn verify -Dspotless.apply.skip -Dcheckstyle.skip
-Dspotless.apply.skip -Dlicense.skip=true` with Java 20 and it seems that we
have problems with Mockito.
We should upgrade to Mockito 5.x, which requires Java 11 and should work
with modern Java versions. See
https://github.com/mockito/mockito/releases/tag/v5.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
