gortiz commented on code in PR #10528:
URL: https://github.com/apache/pinot/pull/10528#discussion_r1211210876
##########
.github/workflows/pinot_tests.yml:
##########
@@ -120,16 +124,20 @@ jobs:
if: github.repository == 'apache/pinot'
runs-on: ubuntu-latest
strategy:
+ # Changed to false in order to improve coverage using unsafe buffers
+ fail-fast: false
matrix:
testset: [ 1, 2 ]
- name: Pinot Integration Test Set ${{ matrix.testset }}
+ java: [ 11, 17, 20 ]
+ distribution: [ "temurin" ]
+ name: Pinot Integration Test Set ${{ matrix.testset }}
(${{matrix.distribution}}-${{matrix.java}})
Review Comment:
> will the github actions end to end now take 6 times as longer than before?
Or would they run in parallel?
They will run in parallel. Tests on this branch finish in about 1 hour, as
usual.
> do we know that we have enough resources on there to handle the increased
num tasks?
I don't know the resources we have. We are going to consume more resources
for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
