gortiz commented on code in PR #10528:
URL: https://github.com/apache/pinot/pull/10528#discussion_r1204114044


##########
pom.xml:
##########
@@ -1096,7 +1096,7 @@
       <dependency>
         <groupId>org.mockito</groupId>
         <artifactId>mockito-core</artifactId>
-        <version>3.9.0</version>
+        <version>3.12.4</version>

Review Comment:
   This version was needed in order to run tests in Java 17 and 20. Version 4.x 
is the one that officially support modern Java versions, but they removed 
deprecated apis there, so just in case we may be using them, I preferred to 
leave it with a 3.x version that seem to work.



##########
pom.xml:
##########
@@ -1096,7 +1096,7 @@
       <dependency>
         <groupId>org.mockito</groupId>
         <artifactId>mockito-core</artifactId>
-        <version>3.9.0</version>
+        <version>3.12.4</version>

Review Comment:
   This version was needed in order to run tests in Java 17 and 20. Version 4.x 
is the one that officially support modern Java versions, but they removed 
deprecated apis there, so just in case we may be using them, I decided to leave 
it with a 3.x version that seem to work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to