gortiz commented on code in PR #10528: URL: https://github.com/apache/pinot/pull/10528#discussion_r1204117789
########## pom.xml: ########## @@ -1343,6 +1355,14 @@ </systemPropertyVariables> <trimStackTrace>false</trimStackTrace> <reportFormat>plain</reportFormat> + <argLine> + ${argLine} Review Comment: I spend several days trying to be able to add the --add-opens we need without making some esoteric maven plugin or profile to fail. This is the solution I found and it seems to be the official one. What this does is to expand the argLine property we set in our different profiles and then add the --add-opens we need in Java > 16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org