zhtaoxiang commented on PR #10387: URL: https://github.com/apache/pinot/pull/10387#issuecomment-1459647084
> > @jtao15 > > Can we name both the new mode and the old mode? For example `StartingFromEarliest` and `StartingFromBreakingPoint`? And we default to `StartingFromBreakingPoint`. > > This way, it's easy for users to understand. The name `loopBack` seems not easy to follow. > > @zhtaoxiang How about `processAll` and `processFromWatermark` since we are mentioning the watermark in Apache Pinot docs already? sounds good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
