jtao15 commented on code in PR #10387:
URL: https://github.com/apache/pinot/pull/10387#discussion_r1129011874
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -211,6 +217,10 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
}
}
+ // Get scheduling mode which is "one-off" by default. If "lookBack" mode
is enabled, there will be no
+ // watermark, and each round we pick the buckets in chronological order
which have unmerged segments.
+ boolean isLookBack =
"lookBack".equalsIgnoreCase(taskConfigs.get(MergeTask.MODE));
Review Comment:
As mentioned in other comments, updated to `processAll` and
`processFromWatermark` as the constants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
