jtao15 commented on code in PR #10387:
URL: https://github.com/apache/pinot/pull/10387#discussion_r1129001693
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -260,9 +270,13 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
// Get watermark from MergeRollupTaskMetadata ZNode
Review Comment:
Yep, updated.
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -277,8 +291,14 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
}
// Create delay metrics even if there's no task scheduled, this helps
the case that the controller is restarted
Review Comment:
This apply to the new metric as well, removed "delay" to make it clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
