jtao15 commented on code in PR #10387:
URL: https://github.com/apache/pinot/pull/10387#discussion_r1129952952
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -792,9 +960,20 @@ private void cleanUpDelayMetrics(List<TableConfig>
tableConfigs) {
Map<String, String> taskConfigs =
currentTableConfig.getTaskConfig().getConfigsForTaskType(getTaskType());
Map<String, Map<String, String>> mergeLevelToConfigs =
MergeRollupTaskUtils.getLevelToConfigMap(taskConfigs);
Map<String, Long> tableToWatermark =
_mergeRollupWatermarks.get(tableNameWithType);
- for (String mergeLevel : tableToWatermark.keySet()) {
- if (!mergeLevelToConfigs.containsKey(mergeLevel)) {
- resetDelayMetrics(tableNameWithType, mergeLevel);
+ if (tableToWatermark != null) {
Review Comment:
`_mergeRollupWatermarks` map is used to emit the old
`mergeRollupTaskDelayInNumBuckets` metric and will be set for the default mode.
The new `processAll` mode does not emit the old metric, and won't set this map,
so this can be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
