egalpin commented on PR #10234: URL: https://github.com/apache/pinot/pull/10234#issuecomment-1442485990
The memory overhead really starts to add up. Now that I have the context that the upsert config cannot change without server restart, I feel that this design can be re-implemented using an array of size `_comparisonColumns.size()`, and the column names themselves would not need to be stored per PK. @Jackie-Jiang thoughts on using an array indexed by the order of _comparisonColumns? As opposed to map implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
