egalpin commented on PR #10234: URL: https://github.com/apache/pinot/pull/10234#issuecomment-1431807205
Ok @Jackie-Jiang I think I've got this now. The change _does_ coerce `comparisonColumn` String to be a list of size one, but the semantics are such that these configurations are the same: `"comparisonColumn": "foo"` == `"comparisonColumns": ["foo"]` In both those cases, the code paths will be "unchanged" from how they work today: no wrapping of Comparable in `ComparisonColumns`, only a single `PinotSegmentColumnReader` rather than a map when using multiple comparisonColumns, etc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
