egalpin commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1120717264
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ComparisonColumns.java: ########## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.upsert; + + +@SuppressWarnings({"rawtypes", "unchecked"}) +public class ComparisonColumns implements Comparable<ComparisonColumns> { + private Comparable[] _comparisonColumns; + + public ComparisonColumns(Comparable[] comparisonColumns) { + _comparisonColumns = comparisonColumns; + } + + public Comparable[] getComparisonColumns() { + return _comparisonColumns; + } + + @Override + public int compareTo(ComparisonColumns other) { + // _comparisonColumns should only at most one non-null comparison value. If not, it is the user's responsibility. + // There is no attempt to guarantee behavior in the case where there are multiple non-null values + int comparisonResult; + int comparableIndex = getComparableIndex(); + + if (comparableIndex < 0) { + // All comparison values were null. This record is only ok to keep if all prior values were also null Review Comment: It's currently allowed in this change set in order to maintain parity with the case of a using a singular comparisonColumn. Currently, if the comparison value is null it will take <default value> for the column. If a subsequent record for the same PK also has a null comparison value, it will take <default value> for the column and end up with `compareTo` being `0` which results in the record being kept. Allowing all values to be null when using multiple comparison columns would maintain this behaviour. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
