Ferix9288 commented on PR #10139:
URL: https://github.com/apache/pinot/pull/10139#issuecomment-1404059312

   Hey @Jackie-Jiang ,
   
   I just pulled the latest snapshot from yesterday 
(0.13.0-SNAPSHOT-9105a06ce8-20230125) but seems like my fixes in this PR never 
appears baked in the image. Is there potentially another step I'm missing that 
you know about?
   
   Like the Dockerfile supposedly should have pulled and grabbed the changes 
(it's how I created my custom image):
   
   ```
   ENV PINOT_HOME=/opt/pinot
   ENV JAVA_OPTS="-Xms4G -Xmx4G -Dpinot.admin.system.exit=false"
   
   VOLUME ["${PINOT_HOME}/configs", "${PINOT_HOME}/data"]
   
   COPY --from=pinot_build_env ${PINOT_HOME} ${PINOT_HOME}
   COPY bin ${PINOT_HOME}/bin
   COPY etc ${PINOT_HOME}/etc
   COPY examples ${PINOT_HOME}/examples
   
   RUN wget -O 
${PINOT_HOME}/etc/jmx_prometheus_javaagent/jmx_prometheus_javaagent-0.12.0.jar 
https://repo1.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/0.12.0/jmx_prometheus_javaagent-0.12.0.jar
   RUN wget -O 
${PINOT_HOME}/etc/jmx_prometheus_javaagent/jmx_prometheus_javaagent-0.16.1.jar 
https://repo1.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/0.16.1/jmx_prometheus_javaagent-0.16.1.jar
 && \
       ln -s 
${PINOT_HOME}/etc/jmx_prometheus_javaagent/jmx_prometheus_javaagent-0.16.1.jar 
${PINOT_HOME}/etc/jmx_prometheus_javaagent/jmx_prometheus_javaagent.jar
   ```
   
   Maybe I need to cherry-pick this fix into a different feature branch where 
snapshots are created from?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to