Ferix9288 commented on PR #10139: URL: https://github.com/apache/pinot/pull/10139#issuecomment-1396699401
Hey @Jackie-Jiang , much appreciated for the prompt review! Ah very nice. So possibly a non-greedy search like (.*?)_(\w+)? And np, I will fix the other regexes that also contain label `table` (but without the suffix) once we agree upon the new regex to match the table name more liberally. > When the table name contains _, can it correctly match the name? Ah that's an excellent point. Yes, if a table name was something like `fake_table`, then regex will match this and deem it valid. However, code-wise and from what I've witnessed, the proper suffix is always appended to it. We could make it: `(.*?)_(OFFLINE|REALTIME)` and be more explicit though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
