Ferix9288 commented on PR #10139:
URL: https://github.com/apache/pinot/pull/10139#issuecomment-1396918251

   Thanks @richardstartin for the input! 
   
   @Jackie-Jiang I added `\\S+` regex to all other instances in which there was 
a `table` label; good catch on that. Also are we sure we should let whitespaces 
for table names? Wouldn't that kill a lot of the controller APIs that requires 
{{tableName}}? Or would encoding it as `%20` work? I am not sure if Pinot 
Controller UI would handle all of that correctly.
   
   Sidenote: I created my own pinot custom image that has my changes baked in. 
Can confirm that this fixes our usecase and issue mentioned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to