Ferix9288 commented on code in PR #10139:
URL: https://github.com/apache/pinot/pull/10139#discussion_r1083169734
##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/broker.yml:
##########
@@ -1,71 +1,71 @@
rules:
-- pattern: "\"org.apache.pinot.common.metrics\"<type=\"BrokerMetrics\",
name=\"pinot.broker.(\\w+).authorization\"><>(\\w+)"
+- pattern: "\"org.apache.pinot.common.metrics\"<type=\"BrokerMetrics\",
name=\"pinot.broker.(.*?).authorization\"><>(\\w+)"
name: "pinot_broker_authorization_$2"
cache: true
labels:
table: "$1"
-- pattern: "\"org.apache.pinot.common.metrics\"<type=\"BrokerMetrics\",
name=\"pinot.broker.(\\w+)\\.documentsScanned\"><>(\\w+)"
+- pattern: "\"org.apache.pinot.common.metrics\"<type=\"BrokerMetrics\",
name=\"pinot.broker.(.*?)\\.documentsScanned\"><>(\\w+)"
Review Comment:
Great question. I think the correct pattern is having `\\.` but because `.`
is a wildcard, it works regardless.
Ex:
pinotAbroker would still match regex `pinot.broker`
Requires another PR to fix this pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
