klsince commented on code in PR #10089:
URL: https://github.com/apache/pinot/pull/10089#discussion_r1073947901
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java:
##########
@@ -207,11 +207,7 @@ private boolean needProcessStarTrees() {
List<StarTreeV2Metadata> starTreeMetadataList =
_segmentMetadata.getStarTreeV2MetadataList();
// There are existing star-trees, but if they match the builder configs
exactly,
// then there is no need to generate the star-trees
- if (starTreeMetadataList != null && !StarTreeBuilderUtils
- .shouldRemoveExistingStarTrees(starTreeBuilderConfigs,
starTreeMetadataList)) {
- return false;
- }
- return !starTreeBuilderConfigs.isEmpty();
+ return
StarTreeBuilderUtils.existingStarTreesNeedChange(starTreeBuilderConfigs,
starTreeMetadataList);
Review Comment:
Good catch!
Instead of changing the shouldRemoveExistingStarTrees(), could it work in
this way?
```
// falling out of the if-check means there are new changes:
// either adding ST trees per new configs, or remove all existing ST trees
return !starTreeBuilderConfigs.isEmpty() || starTreeMetadataList != null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
