saurabhd336 commented on code in PR #10089: URL: https://github.com/apache/pinot/pull/10089#discussion_r1087359827
########## pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterIntegrationTestUtils.java: ########## @@ -286,7 +286,7 @@ public static void buildSegmentFromAvro(File avroFile, TableConfig tableConfig, org.apache.pinot.spi.data.Schema schema, int segmentIndex, File segmentDir, File tarDir) throws Exception { // Test segment with space and special character in the file name - buildSegmentFromAvro(avroFile, tableConfig, schema, segmentIndex + " %", segmentDir, tarDir); + buildSegmentFromAvro(avroFile, tableConfig, schema, segmentIndex + "_", segmentDir, tarDir); Review Comment: This is actually my bad. Was testing a few things. This is an issue when working with S3, but I'm fixing that separately here https://github.com/apache/pinot/pull/10055. Commits got mixed up. Reverted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org