saurabhd336 commented on code in PR #10089:
URL: https://github.com/apache/pinot/pull/10089#discussion_r1070868651
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -355,13 +356,37 @@ public void reloadSegment(String segmentName,
IndexLoadingConfig indexLoadingCon
indexLoadingConfig.setInstanceTierConfigs(_tableDataManagerConfig.getInstanceTierConfigs());
File indexDir = getSegmentDataDir(segmentName, segmentTier,
indexLoadingConfig.getTableConfig());
try {
+ boolean shouldDownload = forceDownload || !hasSameCRC(zkMetadata,
localMetadata);
+
+ if (!shouldDownload && (zkMetadata.getTier().equals(segmentTier))) {
Review Comment:
@klsince Owing to the complexities involving
TierBasedSegmentDirectoryLoader::load (it can move an existing non backup
directory to new data dir if not used with a backup dir, etc), I think it might
make sense to use this exclusively for cases where no tier change is involved.
LMK what you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
