saurabhd336 commented on code in PR #10089:
URL: https://github.com/apache/pinot/pull/10089#discussion_r1083677155
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -403,6 +417,16 @@ public void reloadSegment(String segmentName,
IndexLoadingConfig indexLoadingCon
}
}
+ public boolean canReuseExistingDirectoryForReload(SegmentZKMetadata
segmentZKMetadata,
+ String currentSegmentTier, SegmentDirectory segmentDirectory,
IndexLoadingConfig indexLoadingConfig,
+ Schema schema)
+ throws Exception {
+ SegmentDirectoryLoader segmentDirectoryLoader =
+
SegmentDirectoryLoaderRegistry.getSegmentDirectoryLoader(indexLoadingConfig.getSegmentDirectoryLoader());
+ return
!segmentDirectoryLoader.needsTierMigration(segmentZKMetadata.getTier(),
currentSegmentTier)
+ && !ImmutableSegmentLoader.needPreprocess(segmentDirectory,
indexLoadingConfig, schema);
Review Comment:
Ack
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/loader/SegmentDirectoryLoader.java:
##########
@@ -42,4 +41,13 @@ SegmentDirectory load(URI indexDir,
SegmentDirectoryLoaderContext segmentDirecto
default void delete(SegmentDirectoryLoaderContext
segmentDirectoryLoaderContext)
throws Exception {
}
+
+ /**
+ * Based on the zkMetadata's and current segment tier, checks whether or not
tier migration is needed
+ * @param zkTier segment's ZKMetadata's tier
+ * @param currentTier Current segment tier
+ */
+ default boolean needsTierMigration(String zkTier, String currentTier) {
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
