agavra commented on code in PR #9962:
URL: https://github.com/apache/pinot/pull/9962#discussion_r1047557013
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java:
##########
@@ -98,9 +108,12 @@ public void runJob() {
// not complete, needs to re-register for scheduling
register(operatorChain, false);
} else {
- LOGGER.debug("({}): Completed {}",
- operatorChain,
- operatorChain.getStats());
+ if (result.isErrorBlock()) {
+ LOGGER.error("({}): Completed erroneously {} {}",
operatorChain, operatorChain.getStats(),
+ result.getDataBlock().getExceptions());
+ } else {
+ LOGGER.debug("({}): Completed {}", operatorChain,
operatorChain.getStats());
Review Comment:
it's the only debug log in the class, so we can always turn on debug just
for this class if we want to in prod. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
