agavra commented on code in PR #9962:
URL: https://github.com/apache/pinot/pull/9962#discussion_r1047543621


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java:
##########
@@ -59,6 +62,12 @@ public class QueryConfig {
   public static final String KEY_OF_SERVER_RESPONSE_STATUS_ERROR = "ERROR";
   public static final String KEY_OF_SERVER_RESPONSE_STATUS_OK = "OK";
 
+  /**
+   * Configuration keys for managing the scheduler
+   */
+  public static final String KEY_OF_SCHEDULER_RELEASE_TIMEOUT_MS = 
"pinot.query.scheduler.release.timeout.ms";
+  public static final long DEFAULT_SCHEDULER_RELEASE_TIMEOUT_MS = 
TimeUnit.MINUTES.toSeconds(1);

Review Comment:
   The idea was to make sure this timeout is not hit in regular processing - I 
will set the default to `-1` and handle that appropriately. At some point, when 
we're ready to enable the defensive scheduling, we can give more thought to 
what we want this timeout to be.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to