agavra commented on code in PR #9962:
URL: https://github.com/apache/pinot/pull/9962#discussion_r1047537391
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java:
##########
@@ -98,9 +108,12 @@ public void runJob() {
// not complete, needs to re-register for scheduling
register(operatorChain, false);
} else {
- LOGGER.debug("({}): Completed {}",
- operatorChain,
- operatorChain.getStats());
+ if (result.isErrorBlock()) {
+ LOGGER.error("({}): Completed erroneously {} {}",
operatorChain, operatorChain.getStats(),
+ result.getDataBlock().getExceptions());
+ } else {
+ LOGGER.debug("({}): Completed {}", operatorChain,
operatorChain.getStats());
Review Comment:
I feel like that's a lot of logging, are we sure we're OK with that? I guess
we can always disable it if we want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
