walterddr commented on code in PR #9962:
URL: https://github.com/apache/pinot/pull/9962#discussion_r1046610518
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java:
##########
@@ -59,6 +62,12 @@ public class QueryConfig {
public static final String KEY_OF_SERVER_RESPONSE_STATUS_ERROR = "ERROR";
public static final String KEY_OF_SERVER_RESPONSE_STATUS_OK = "OK";
+ /**
+ * Configuration keys for managing the scheduler
+ */
+ public static final String KEY_OF_SCHEDULER_RELEASE_TIMEOUT_MS =
"pinot.query.scheduler.release.timeout.ms";
+ public static final long DEFAULT_SCHEDULER_RELEASE_TIMEOUT_MS =
TimeUnit.MINUTES.toSeconds(1);
Review Comment:
could you comment on why this default value is being chosen. I am sensing it
is related to the default mailbox timeout, but if someone set timeout =
120second. isn't this going to cause problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
