[GitHub] [pinot] mcvsubbu commented on a diff in pull request #9224: Extract record keys, headers and metadata from Stream sources

[GitBox]

mcvsubbu commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r980631968


##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/RowMetadata.java:
##########
@@ -39,5 +44,27 @@ public interface RowMetadata {
    * @return timestamp (epoch in milliseconds) when the row was ingested 
upstream
    *         Long.MIN_VALUE if not available
    */
-  long getIngestionTimeMs();
+  long getRecordTimestampMs();

Review Comment:
   The API will be used by folks writing plugins for a new stream.  Imagine if 
you are writing a new stream, and need to implement getRecordTimeStamp() but 
your stream does not provide any field called RecordTimeStamp (but provides 
other ways to get the ingestion time).
   
   And hence my suggestion.
   
   I will let you decide.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org