mcvsubbu commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r980329107
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/RowMetadata.java:
##########
@@ -39,5 +44,27 @@ public interface RowMetadata {
* @return timestamp (epoch in milliseconds) when the row was ingested
upstream
* Long.MIN_VALUE if not available
*/
- long getIngestionTimeMs();
+ long getRecordTimestampMs();
Review Comment:
What is the semantic that you want here? Time at which the record was
ingested into the stream? Time at which the record was generated upstream? Or
some other?
In other words, in Pinot, if I write an expression
`(System.currentTimeMillis() - getRecordTimeStampMs())` what do you expect this
value to signify (independent of any underlying stream, of course)?
As a side note, please modify the javadoc with the answer to the q above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
