navina commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r980754445
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/RowMetadata.java:
##########
@@ -39,5 +44,27 @@ public interface RowMetadata {
* @return timestamp (epoch in milliseconds) when the row was ingested
upstream
* Long.MIN_VALUE if not available
*/
- long getIngestionTimeMs();
+ long getRecordTimestampMs();
Review Comment:
I was one of the folks writing plugin for a new stream and it wasn't clear
to me :)
I am fine changing it to `recordIngestionTime`. Previously, it was just
"ingestionTime" and it was within "RowMetadata". So, altogether, it didn't make
sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
