navina commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r979753631
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/RowMetadata.java:
##########
@@ -39,5 +44,27 @@ public interface RowMetadata {
* @return timestamp (epoch in milliseconds) when the row was ingested
upstream
* Long.MIN_VALUE if not available
*/
- long getIngestionTimeMs();
+ long getRecordTimestampMs();
Review Comment:
I disagree here. I don't think the semantics are clear.
1. Ingestion time is vague. It can be interpreted as the time at which the
record was ingested into Pinot table or the time at which the record was
ingested into the upstream source. Looking at the implementation today, it
seems to refer to the latter case. So , recordtimestamp is more accurate as it
is the timestamp which comes with the incoming stream record.
2. Oddly enough, this interface is named `RowMetadata`. However, a row is
usually an entity in a table. It is not typically referred to the data in a
streaming source. We need to start making the distinction more clear in Pinot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
